do not wipe out existing connection resource requirements on update #10291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
jrhizor
approved these changes
Feb 11, 2022
jrhizor
suggested changes
Feb 11, 2022
| @@ -74,7 +79,21 @@ public ConnectionRead updateConnection(final ConnectionUpdate connectionUpdate) | |||
| .withMemoryRequest(connectionUpdate.getResourceRequirements().getMemoryRequest()) | |||
| .withMemoryLimit(connectionUpdate.getResourceRequirements().getMemoryLimit())); | |||
| } else { | |||
| newConnection.withResourceRequirements(workerConfigs.getResourceRequirements()); | |||
| final io.airbyte.config.ResourceRequirements resourceRequirements = Optional.ofNullable(persistedSync.getResourceRequirements()) | |||
There was a problem hiding this comment.
Don't we want to leave them blank so we use the workerConfig at job creation time, not in the connection update?
There was a problem hiding this comment.
Yeah you're right, this class should not be pulling resource requirements from the worker configs at all. I will update
cgardens
approved these changes
Feb 11, 2022
lmossman
deleted the
lmossman/do-not-wipe-out-existing-resource-requirements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Today when a connection is updated, its currently-set
resource_requirementsare wiped out if the update input does not include new resource requirements.This is bad because we are currently using connection
resource_requirementsto bump the resource limits of a connection, and wiping these out can lead to more failures. This has already happened once: https://airbytehq-team.slack.com/archives/C02U46QK5C3/p1644618998737659?thread_ts=1644599694.890299&cid=C02U46QK5C3How
This PR solves the issue by adding logic to use already-existing resource_requirement values on connection update if the update input does not include new values.